Skip to content

Conversation

@aerooneqq
Copy link
Contributor

@aerooneqq aerooneqq commented Dec 1, 2025

This PR relates to the delegation feature #118212, it fixes #148889 ICE.
r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2025
@rustbot

This comment has been minimized.

Copy link
Contributor

@reddevilmidzy reddevilmidzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fixes the #148889 ICE.

You have to remove 'the' to have GitHub automatically close the issue.

View changes since this review

@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Dec 1, 2025
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

📌 Commit 62fe6a0 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025
bors added a commit that referenced this pull request Dec 1, 2025
Rollup of 9 pull requests

Successful merges:

 - #148690 (Implement `clamp_magnitude` method for primitive floats & signed integers)
 - #149102 (stabilize maybe_uninit_slice)
 - #149269 (cmse: do not calculate the layout of a type with infer types)
 - #149299 (Fudge infer vars in the cause code of `Obligation` intentionally)
 - #149344 (Don't suggest unwrap for Result in const)
 - #149358 (fix(parse): Limit frontmatter fences to 255 dashes )
 - #149445 (make assoc fn inherit const stability from inherent `const impl` blocks)
 - #149479 (Fix indent in E0591.md)
 - #149496 (Fix #148889: Add label rib when visiting delegation body)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0091c5 into rust-lang:main Dec 1, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 1, 2025
Rollup merge of #149496 - aerooneqq:ice-issue-148889, r=petrochenkov

Fix #148889: Add label rib when visiting delegation body

This PR relates to the delegation feature #118212, it fixes #148889 ICE.
r? `@petrochenkov`
@rustbot rustbot added this to the 1.93.0 milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: no entry found for key in compiler/rustc_ast_lowering/src/expr.rs

5 participants